[master] Only run space check in TUI if spokes are complete. (#1279413)

Samantha N. Bueno sbueno+anaconda at redhat.com
Tue Nov 10 17:19:35 UTC 2015


Especially if there are packaging setup errors, this causes the storage
attr to be unset, which causes issues when the FS space check is run.
Well, probably this check is safest to run if/when there are no
incomplete spokes, so restrict it to that.

Resolves: rhbz#1279413
---
 pyanaconda/ui/tui/hubs/summary.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/pyanaconda/ui/tui/hubs/summary.py b/pyanaconda/ui/tui/hubs/summary.py
index 489138a..035b759 100644
--- a/pyanaconda/ui/tui/hubs/summary.py
+++ b/pyanaconda/ui/tui/hubs/summary.py
@@ -75,12 +75,11 @@ class SummaryHub(TUIHub):
 
         # do a bit of final sanity checking, make sure pkg selection
         # size < available fs space
-        if flags.automatedInstall:
+        if flags.automatedInstall and not incompleteSpokes:
             if self._checker and not self._checker.check():
                 print(self._checker.error_message)
-            if not incompleteSpokes:
-                self.close()
-                return None
+            self.close()
+            return None
 
         if flags.ksprompt:
             for spoke in incompleteSpokes:
-- 
2.4.3



More information about the anaconda-patches mailing list