[rhinstaller/anaconda/pulls/439 master] Glade tests

jkonecny12 installerbot-noreply at redhat.com
Fri Nov 6 10:45:06 UTC 2015


> @@ -0,0 +1,52 @@
> +#
> +# Copyright (C) 2015  Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU Lesser General Public License as published
> +# by the Free Software Foundation; either version 2.1 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU Lesser General Public License for more details.
> +#
> +# You should have received a copy of the GNU Lesser General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +# Author: David Shea <dshea at redhat.com>
> +#
> +
> +from gladecheck import GladeTest
> +
> +class CheckTranslatableTreeview(GladeTest):
> +    def checkGlade(self, glade_tree):
> +        """Check that unshown GtkTreeview column headers are not translatable.
> +
> +           These values are not displayed and should not be translated.
> +        """
> +
> +        # Look for
> +        # <object class="GtkTreeView">
> +        #   <property name="headers_visible">False</property>
> +        #   ...
> +        #   <child>
> +        #     <object class="GtkTreeViewColumn">
> +        #       <property name="title" translatable="yes">...
> +
> +        for translatable in glade_tree.xpath(".//object[@class='GtkTreeView' and ./property[@name='headers_visible' and ./text() = 'False']]/child/object[@class='GtkTreeViewColumn']/property[@name='title' and @translatable='yes']"):

I'm thinking that these rows (one more few lines lower) could be split to shorter parts. Maybe it would be nice to store this in variable first before the for loop.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/439#discussion_r44124337


More information about the anaconda-patches mailing list