Take 03: libblockdev s390 things

Vratislav Podzimek vpodzime at redhat.com
Wed May 20 11:55:29 UTC 2015


On Tue, 2015-05-19 at 22:30 -0400, Samantha N. Bueno wrote:
> This introoduces the libblockdev s390 plugin and adapts blivet and
> anaconda code for the changes.
> The only s390-related functions not moved into libblockdev as of this
> moment are the zfcp online/offline functions. They're terrible. They'll
> be moved a little later.
> 
> Issues fixed in this edition:
> -- s390x tests are all arch specific
> -- Various other minor errors pointed out by vpodzime
Other than the last few things I pointed out in the replies (one of them got sent outside of the
email thread) this looks good to me. All those things are easy fixes so feel free to do them before
pushing. There's no need to send "Take 04". Just please make sure it compiles and tests run. :)

Thanks for your patience and all the work on this plugin!

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list