[anaconda] Make anaconda changes necessary for libblockdev s390 plugin.

Anne Mulhern amulhern at redhat.com
Mon May 18 16:52:51 UTC 2015





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, May 18, 2015 8:44:03 AM
> Subject: Re: [anaconda] Make anaconda changes necessary for libblockdev s390	plugin.
> 
> On Mon, 2015-05-18 at 08:30 -0400, Anne Mulhern wrote:
> > <-- SNIP -->
> > 
> > > 
> > > 2)
> > > with libblockdev's functionality being used directly from anaconda, we
> > > need to make sure the library is initialized (i.e. plugins are loaded)
> > > somewhere in anaconda. I think we could just check if blivet did it for
> > > us and if all plugins anaconda needs (s390) are loaded somewhere after
> > > we import blivet for the first time.
> > > 
> > > --
> > > Vratislav Podzimek
> > > 
> > > Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> > > 
> > > _______________________________________________
> > > anaconda-patches mailing list
> > > anaconda-patches at lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > > 
> > 
> > It seems roundabout to check whether blivet has loaded a plugin that
> > anaconda
> > uses directly.
> > 
> > It would make more sense just to have anaconda load that plugin.
> > AFAICT, the only reason not to is if loading the s390 plugin specifically
> > causes
> > all other plugins to be unloaded. But, in that case, as a work around,
> > anaconda
> > can obtain a list of all the plugins
> > loaded, and if s390 is missing add it to the list of plugins, and load them
> > all again.
> > This may not be much different from your suggestion, except that it leaves
> > blivet
> > out of the picture.
> That's exactly what I meant. I just think we should let blivet load
> whatever it wants/needs first and then check if the s390 plugin was
> among the wanted/needed ones or not. If not, just load it (as described
> below)
> 
> > 
> > I guess that the ideal case would be an ability to load an individual
> > plugin as
> > required, without affecting the loadedness of the other plugins.
> This is possible. 'bd_reinit([s390_plugin_spec], reload=False)' should
> do exactly that.
> 

Great! Problem is already solved, then.

- mulhern

> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list