[rhinstaller/anaconda/pulls/98 master] Fix bad IP checker in text installation

kellinm installerbot-noreply at redhat.com
Tue May 12 14:11:37 UTC 2015


The alternate ticket is BZ 1174451.

I think I worded my intentions wrong - I do not think it's worthwhile to validate whether an address exists on a network as that introduces too much uncertainty and timeout issues.

I meant capturing the conversion-to-address errors.

EG: Try to make it throw a similar error to this which is simply the inability to convert it to an IP and catch it.

File "/usr/lib64/python2.7/site-packages/pyanaconda/nm.py", line 870, in nm_ipv4_to_dbus_int
    return struct.unpack("=L", socket.inet_aton(address))[0]

This means that - even *if* the regular expression fails to catch the problem - we will have caught the error and put a reasonable error message into the logs.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/98


More information about the anaconda-patches mailing list