[PATCH master] rpmostreepayload: write storage config after shared var is mounted (#1203234)

Brian C. Lane bcl at redhat.com
Wed Mar 18 14:45:39 UTC 2015


On Wed, Mar 18, 2015 at 01:40:08PM +0100, Radek Vykydal wrote:
> iscsi configuratiion is written to /var/lib/iscsi so we need to have
> the shared /var already mounted to deployment
> ---
>  pyanaconda/install.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/pyanaconda/install.py b/pyanaconda/install.py
> index a68e793..f09c772 100644
> --- a/pyanaconda/install.py
> +++ b/pyanaconda/install.py
> @@ -230,7 +230,6 @@ def doInstall(storage, payload, ksdata, instClass):
>          if iutil.getSysroot() != iutil.getTargetPhysicalRoot():
>              blivet.setSysroot(iutil.getTargetPhysicalRoot(),
>                                iutil.getSysroot())
> -            storage.write()
>  
>              # Now that we have the FS layout in the target, umount
>              # things that were in the legacy sysroot, and put them in
> @@ -249,8 +248,7 @@ def doInstall(storage, payload, ksdata, instClass):
>              # since the bootloader code will expect to find /boot
>              # inside the chroot.
>              storage.mountFilesystems(skipRoot=True)
> -        else:
> -            storage.write()
> +        storage.write()
>  
>      # Do bootloader.
>      if willInstallBootloader:
> -- 
> 1.9.3

I'd like to see what Colin says about this, commit 0bbc9adf41b33 is what
changed all that last time and I don't want to see us fix it for one
thing and break for another :)

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list