[master 3/5] Add dynamic mountpoint detection support

dwlehman installerbot-noreply at redhat.com
Tue Mar 17 15:46:31 UTC 2015


I like the direction this is going.

Some comments:

1. MountsCache would make a good singleton. This would save adding the cache as an
    attribute of DeviceTree or DeviceFormat. I don't see any reason to ever have more than
    one instance of this class.
2. It would be nice if the cache.add() calls were not required.



-- 
To view this comment on github, visit https://github.com/vojtechtrefny/blivet/commit/f8d29e630f93f52f7ef6d893074696b0c974deb9#commitcomment-10239902


More information about the anaconda-patches mailing list