[rhinstaller/blivet/pulls/47 master] Dynamic mountpoint detection

vpodzime installerbot-noreply at redhat.com
Tue Mar 17 09:29:46 UTC 2015


> I think mountCache should be in FS not DeviceFormat. AFAICT, the only thing about mounting in DeviceFormat is mountable, and there is a ton of stuff about mounting in FS.

If I understand it correctly, having mountCache in FS not in DeviceFormat would require all the code that tries to get/set it on a ``device.format`` check if that format is a ``FS`` first. I think not having to do this checks is a nice benefit of having it one level higher in the class hierarchy.

> When tasks infrastructure goes in, MountsCache should be factored out into an always available Task and the rest of it. Please take a look at https://github.com/mulkieran/blivet/tree/master-tasks and work out how you would do that, and send me a link for that branch. A PR would probably just make the list too busy.

I think the priority of this depends on in which order we want to merge this and the tasks infrastructure. If this is the first thing to go in, we should focus on merging this and then on "rebasing" the tasks infrastructure.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/47


More information about the anaconda-patches mailing list