[rhinstaller/blivet/pulls/46 f22-branch] Fix XFS' and BTRFS' max size limits (#1200812)

vpodzime installerbot-noreply at redhat.com
Mon Mar 16 13:21:14 UTC 2015


@mulkieran posted to bugzilla:
> In bytesize, it will not be possible, or at least it will be discouraged, to add numbers to sizes (or subtract numbers from sizes). That's not the real problem with this patch, though.
Exactly. That is to be resolved once we switch to bytesize.

> *) You haven't confirmed that xfs or btrfs are actually constrained to this number...maybe they store all values as multiples of sectors. We should make sure that we know the _actual_ limits of these two, probably by asking, before we make a patch based on their actual limits.
Or we could just not waste time by doing that since it really doesn't matter at all now and wont' matter in near or even distant future.

> *) This doesn't fix the problem of the way that libblockdev represents integers, even in this particular instance. It is true that this particular test case will no longer raise that particular exception. But, it will do the wrong thing, because the integer will overflow in bd_lvm_round_size_to_pe, since it is rounding up. A quick glance seems to indicate that the result of rounding 2^64 - 1 up to the nearest pe_size boundary will return pe_size, which is wrong.
That is a valid point that has to be addressed.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/46


More information about the anaconda-patches mailing list