[lorax master/f22] include variant in the name for .treeinfo when it exists

Brian C. Lane bcl at redhat.com
Tue Mar 10 16:13:15 UTC 2015


On Tue, Mar 10, 2015 at 10:00:29AM -0500, Dennis Gilmore wrote:
> For some further background info on this. while I was working on 
> https://fedorahosted.org/rel-eng/ticket/6008 I realised pungi has been doing 
> things wrong for years. it was not building the file names correctly. it was 
> using name which is the Family. we do not want the Server, Workstation, Cloud 
> install isos to all be named the same. which they would be if we used just 
> Fedora for the name/family.  I renamed everything in pungi to be consistent 
> with the naming in lorax. This patch enables us to get the same behaviour as 
> we had in Fedora 21 but fix up .treeinfo to have the Family be just Fedora 
> which will then result in the Family in the .composeinfo file being Fedora 
> also.
> 
> If you look at the .treeinfo file[2] from Fedora 21 Server you can see that 
> the family field in  the general section is wrong, which translates to the 
> family field in the product section of the .composeinfo[3] file being wrong 
> also. at least to be consistent with what we have done previously we need to 
> add the variant to the name field of the .treeinfo file. if we do not then the 
> name  for all products install trees will be Fedora-22 in fedora 22, maybe 
> that is okay, but I personally do not think so. 
> 
> Dennis
> 
> [1] 
> https://git.fedorahosted.org/cgit/pungi.git/commit/?id=35e5af98184482b66f29471f9e245aa0da5a7bb8
> [2] 
> http://dl.fedoraproject.org/pub/fedora/linux/releases/21/Server/armhfp/os/.treeinfo
> [3] 
> http://dl.fedoraproject.org/pub/fedora/linux/releases/21/Server/.composeinfo

Thanks for the explanation, now this makes more sense. You're trying to
adjust for previous problems by tweaking the .treeinfo format. I think
this is the wrong place to change things. Including the variant in the
name was a bug, and now that's been fixed by the pungi change. If other
things, like creating composeinfo, want the variant name in their fields
then the tool to create that should do it, not lorax.

For comparison, the RHEL examples of .treeinfo that I looked at usee
only the family and the version in the name field, variant has its own
field and is set accordingly.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list