[f21-branch 2/3] Allow passing KiB values to vgcreate -s option

TimothyAsirJeyasing installerbot-noreply at redhat.com
Fri Mar 6 21:06:53 UTC 2015


From: Timothy Asir Jeyasingh <tjeyasin at redhat.com>

Currently blivet exepects pesize parm of the vgcreate function
should be in MiB. Any given value will be converted to MiB format
and omits any fractional part. That means, if any KiB values are
passed to pesize parm, it becomes 0 and the actual lvm lvcreate
faild to create the vg and returns an error.
This limits passing any KiB values for pesize to create a vg.
This patch fixes the issue by accepting the given value in KiB.

Bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1198568
Signed-off-by: Timothy Asir Jeyasingh <tjeyasin at redhat.com>
---
 blivet/devicelibs/lvm.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py
index 1ecad89..a0dc878 100644
--- a/blivet/devicelibs/lvm.py
+++ b/blivet/devicelibs/lvm.py
@@ -339,7 +339,7 @@ def pvinfo(device=None):
 def vgcreate(vg_name, pv_list, pe_size):
     argv = ["vgcreate"]
     if pe_size:
-        argv.extend(["-s", "%sm" % pe_size.convertTo(spec="mib")])
+        argv.extend(["-s", "%sm" % pe_size.convertTo(spec="KiB")])
     argv.extend(_getConfigArgs())
     argv.append(vg_name)
     argv.extend(pv_list)


-- 
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/b2bd1c349ce06e8788594be2c9a84aed90a79fe3


More information about the anaconda-patches mailing list