[rhinstaller/blivet/pulls/33 f21-branch] Allow passing fractional MiB values to vgcreate -s option

mulkieran installerbot-noreply at redhat.com
Wed Mar 4 22:17:51 UTC 2015


Actually, AFAICT vgcreate requires a multiple of 512 bytes, just like lvcreate, if you specify bytes.
But it's totally happy with 0.37K.

It looks to me like lvcreate and vgcreate are both better off using these fractional quantities in both libblockdev/devicelibs to get the values past the lvm censors.

The only other sensible thing is to have libblockdev/devicelibs provide the rounding unit, e.g., 512, to devices somehow, and let them do the rounding. But it would have to be done at the call site. Extending the Size functions convertTo() and roundToNearest() to make this happen would be easy, though.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/33


More information about the anaconda-patches mailing list