[rhinstaller/blivet/pulls/32 master] Master services

mulkieran installerbot-noreply at redhat.com
Wed Mar 4 13:27:37 UTC 2015


> @@ -148,46 +148,15 @@ def __str__(self):
>  
>      @property
>      def packages(self):
> -        """ List of packages required to manage devices of this type.
> -
> -            This list includes the packages required by this device's
> -            format type as well those required by all of its parent
> -            devices.
> -        """
>          packages = super(StorageDevice, self).packages
> -        packages.extend(self.format.packages)
> -        for parent in self.parents:
> -            for package in parent.format.packages:
> -                if package not in packages:
> -                    packages.append(package)
> -
> -        return packages
> -
> -    @property
> -    def services(self):
> -        """ List of services required to manage devices of this type.
> -
> -            This list includes the services required by this device's
> -            format type as well those required by all of its parent
> -            devices.
> -        """
> -        services = super(StorageDevice, self).services
> -        services.extend(self.format.services)
> -        for parent in self.parents:
> -            for service in parent.format.services:
> -                if service not in services:
> -                    services.append(service)
> -
> -        return services
> +        return packages + [p for p in self.format.packages if p not in packages]

Not a compelling one. I was thinking about induction and emphasizing that the expression "p not in packages" did not require the updated version of packages. But I don't make use of that fact any where else. Unless anybody has an objection I'll use the extends version instead.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/32#discussion_r25773656


More information about the anaconda-patches mailing list