[PATCH 0/3] New kickstart tests for repos

Brian C. Lane bcl at redhat.com
Tue Mar 3 16:43:25 UTC 2015


On Tue, Mar 03, 2015 at 09:32:11AM -0500, David Shea wrote:
> On 03/02/2015 06:58 PM, Brian C. Lane wrote:
> >On Mon, Mar 02, 2015 at 02:44:21PM -0500, David Shea wrote:
> >>David Shea (3):
> >>   Fix the handling of nfs:// URLs.
> >>   Add kickstart tests for an NFS instrepo and addon repos.
> >>   Add tests with an FTP instrepo
> >>
> >>  pyanaconda/packaging/yumpayload.py              |  2 +-
> >>  pyanaconda/ui/tui/spokes/source.py              |  2 +-
> >>  tests/kickstart_tests/basic-ftp-yum.ks          | 41 +++++++++++++
> >>  tests/kickstart_tests/basic-ftp-yum.sh          | 56 +++++++++++++++++
> >>  tests/kickstart_tests/basic-ftp.ks              | 41 +++++++++++++
> >>  tests/kickstart_tests/basic-ftp.sh              | 56 +++++++++++++++++
> >>  tests/kickstart_tests/nfs-repo-and-addon-yum.ks | 80 +++++++++++++++++++++++++
> >>  tests/kickstart_tests/nfs-repo-and-addon-yum.sh | 69 +++++++++++++++++++++
> >>  tests/kickstart_tests/nfs-repo-and-addon.ks     | 80 +++++++++++++++++++++++++
> >>  tests/kickstart_tests/nfs-repo-and-addon.sh     | 69 +++++++++++++++++++++
> >>  tests/kickstart_tests/run_kickstart_tests.sh    |  2 +-
> >>  11 files changed, 495 insertions(+), 3 deletions(-)
> >>  create mode 100644 tests/kickstart_tests/basic-ftp-yum.ks
> >>  create mode 100644 tests/kickstart_tests/basic-ftp-yum.sh
> >>  create mode 100644 tests/kickstart_tests/basic-ftp.ks
> >>  create mode 100644 tests/kickstart_tests/basic-ftp.sh
> >>  create mode 100644 tests/kickstart_tests/nfs-repo-and-addon-yum.ks
> >>  create mode 100755 tests/kickstart_tests/nfs-repo-and-addon-yum.sh
> >>  create mode 100644 tests/kickstart_tests/nfs-repo-and-addon.ks
> >>  create mode 100755 tests/kickstart_tests/nfs-repo-and-addon.sh
> >>
> >>-- 
> >>2.1.0
> >These all look ok to me, but I wonder if we really need to reboot them
> >to call them good?
> >
> 
> Probably not, I just copied that from the ostree test. The ftp install is
> the only one I had reboot, maybe if I just write RESULT in %post and nothing
> else, we can assume that hitting %post means it worked?

I think so, since we're testing the source method, not whether the whole
stack of possible things works.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list