[PATCH 2/3] Add kickstart tests for an NFS instrepo and addon repos.

Chris Lumens clumens at redhat.com
Mon Mar 2 20:05:19 UTC 2015


> +prepare() {
> +    ks=$1
> +    tmpdir=$2
> +
> +    if [[ "${TEST_ADDON_NFS_REPO}" == "" ]]; then
> +        echo \$TEST_ADDON_NFS_REPO is not set.
> +        return 1
> +    fi
> +
> +    if [[ "${TEST_ADDON_HTTP_REPO}" == "" ]]; then
> +        echo \$TEST_ADDON_HTTP_REPO is not set.
> +        return 1
> +    fi
> +
> +    if [[ "${TEST_NFS_SERVER}" == "" ]]; then
> +        echo \$TEST_NFS_SERVER is not set
> +        return 1
> +    fi
> +
> +    if [[ "${TEST_NFS_PATH}" == "" ]]; then
> +        echo \$TEST_NFS_PATH is not set
> +        return 1
> +    fi
> +
> +    sed -e "/^nfs/ s|NFS-SERVER|${TEST_NFS_SERVER}|" \
> +        -e "/^nfs/ s|NFS-PATH|${TEST_NFS_PATH}|" \
> +        -e "/^repo/ s|NFS-ADDON-REPO|${TEST_ADDON_NFS_REPO}|" \
> +        -e "/^repo/ s|HTTP-ADDON-REPO|${TEST_ADDON_HTTP_REPO}|" ${ks} > ${tmpdir}/kickstart.ks
> +    echo ${tmpdir}/kickstart.ks
> +}

I'm wondering if it would make sense to start adding a check in the
prepare() functions to also see if the repo is accessible.  This would
have to be done in the ostree test, too.

- Chris


More information about the anaconda-patches mailing list