[master 1/1] Make check-requires errors more readable.

dashea installerbot-noreply at redhat.com
Mon Jun 29 21:23:29 UTC 2015


From: David Shea <dshea at redhat.com>

Only output the parts about packages that are not installed.
---
 Makefile | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index a2b2f5c..96f05ab 100644
--- a/Makefile
+++ b/Makefile
@@ -42,7 +42,15 @@ po-empty:
 
 check-requires:
 	@echo "*** Checking if the dependencies required for testing and analysis are available ***"
-	@echo $(TEST_DEPENDENCIES) | xargs rpm -q
+	@status=0 ; \
+	for pkg in $(TEST_DEPENDENCIES) ; do \
+		test_output="$$(rpm -q "$$pkg")" ; \
+		if [ $$? != 0 ]; then \
+			echo "$$test_output" ; \
+			status=1 ; \
+		fi ; \
+	done ; \
+	exit $$status
 
 test: check-requires
 	@echo "*** Running unittests with $(PYTHON) ***"


-- 
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/7a7857e653124a0395fbddd59c683bd8cd90c790


More information about the anaconda-patches mailing list