[anaconda][rhel7-branch][PATCH 0/2] Fix environment handling

Vratislav Podzimek vpodzime at redhat.com
Mon Jun 29 11:41:24 UTC 2015


On Fri, 2015-06-26 at 15:31 +0200, Martin Kolman wrote:
> So it turns out that there are multiple issues with how we handle environment
> specifications from kickstart:
> 
> 1) an invalid (not known by the payload) environment specified in kickstart causes a crash
> 2) valid human readable environment specifications, such as:
>    "Infrastructure Server", which is the human readable form of "infrastructure-server-environment",
>    are not considered valid, the same thing happens for translated human readable environment names
> 3) environments that have been manually selected in the UI are not written to the output
>    kickstart
> 
> The first patch should fix issues 1) + 3) and the second patch should fix issue 2).
> 
> Martin Kolman (2):
>   Don't crash if incorrect environment is set in kickstart (#1234890)
>   Handle human readable environment names from kickstart (#1234890)
> 
>  pyanaconda/packaging/yumpayload.py   |  14 +++++
>  pyanaconda/ui/gui/spokes/software.py | 117 ++++++++++++++++++++++++++---------
>  2 files changed, 101 insertions(+), 30 deletions(-)
Looks good to me other than the few inline comments/questions.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list