[master 5/5] Default to a string when sorting mountpoints in FSSet.umountFilesystems.

mulkieran installerbot-noreply at redhat.com
Thu Jun 25 11:49:00 UTC 2015


The line numbers deceived me and I ended up looking at the wrong method. It's _mountFilesystems_ that's the suspicious looking one.

You might want to mention the TypeError in the commit message. It's only in Python3 that NoneType and str type objects are incomparable. In Python 2 they compare just fine. Which is probably why no problem was observed until recently.

Otherwise, ack.

-- 
To view this comment on github, visit https://github.com/dwlehman/blivet/commit/f7da3072c5677afbc8330da70a4c9fba5eaf8d9c#commitcomment-11859357


More information about the anaconda-patches mailing list