[master 5/5] Default to a string when sorting mountpoints in FSSet.umountFilesystems.

mulkieran installerbot-noreply at redhat.com
Wed Jun 24 22:39:00 UTC 2015


I don't think this change makes a difference.

It makes a bit more sense to throw out everything that lacks a mountpoint attribute, like:

```
devices = [d for d in devices if hasattr(d.format, "mountpoint")]
devices.sort(key=lambda d: d.format.mountpoint)
```

That way, the code below that accesses the attribute directly, as:

```
if not device.format.mountable or not device.format.mountpoint:
```

won't look so suspicious.


-- 
To view this comment on github, visit https://github.com/dwlehman/blivet/commit/f7da3072c5677afbc8330da70a4c9fba5eaf8d9c#commitcomment-11849444


More information about the anaconda-patches mailing list