[rhinstaller/blivet/pulls/156 master] LVM cache detection, manipulation and reporting

vpodzime installerbot-noreply at redhat.com
Wed Jun 24 07:31:03 UTC 2015


> I have one question wouldn't be better if you move some code to that abstract base classes? Now they are empty and you will end up with the parts of the same code in all child classes I think.

Any example? The problem is that e.g. the [stats reported for Bcache] (http://rhinstaller.github.io/libblockdev/libblockdev-KernelBlockDevices.html#BDKBDBcacheStats) look quite different from [stats reported for the LVM cache] (http://rhinstaller.github.io/libblockdev/libblockdev-LVM.html#BDLVMCacheStats).
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/156


More information about the anaconda-patches mailing list