[master 9/9] Ignore EINTR errors in files unlikely to encounter them

dashea installerbot-noreply at redhat.com
Thu Jun 18 21:03:55 UTC 2015


From: David Shea <dshea at redhat.com>

Don't bother handling EINTR in test scripts and single-threaded scripts
run outside of the anaconda environment
---
 docs/conf.py                                      | 3 +++
 scripts/githooks/pre-commit                       | 4 ++++
 scripts/makebumpver                               | 3 +++
 scripts/makeupdates                               | 3 +++
 tests/dracut_tests/parse-kickstart_test.py        | 5 ++++-
 tests/gettext/gettext_potfiles.py                 | 3 +++
 tests/glade/accelerators/check_accelerators.py    | 3 +++
 tests/glade/format_string/check_format_string.py  | 3 +++
 tests/glade/icons/check_icons.py                  | 3 +++
 tests/glade/markup/check_markup.py                | 3 +++
 tests/glade/pw_visibility/check_invisible_char.py | 3 +++
 tests/glade/pw_visibility/check_pw_visibility.py  | 3 +++
 tests/glade/viewport/check_viewport.py            | 3 +++
 tests/gui/outside/__init__.py                     | 3 +++
 tests/lib/translatepo.py                          | 3 +++
 tests/pyanaconda_tests/iutil_test.py              | 3 +++
 tests/pyanaconda_tests/ks_version_test.py         | 4 ++++
 tests/pyanaconda_tests/simpleconfig_test.py       | 3 +++
 18 files changed, 57 insertions(+), 1 deletion(-)

diff --git a/docs/conf.py b/docs/conf.py
index ebc16ef..eb6971c 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -11,6 +11,9 @@
 # All configuration values have a default; values that are commented out
 # serve to show the default.
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import sys, os
 
 # If extensions (or modules to document with autodoc) are in another directory,
diff --git a/scripts/githooks/pre-commit b/scripts/githooks/pre-commit
index 40ae626..cd4b0b6 100755
--- a/scripts/githooks/pre-commit
+++ b/scripts/githooks/pre-commit
@@ -5,6 +5,10 @@
 
 
 """
+
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import os
 import sys
 from subprocess import check_output, CalledProcessError
diff --git a/scripts/makebumpver b/scripts/makebumpver
index 4042742..f17ad29 100755
--- a/scripts/makebumpver
+++ b/scripts/makebumpver
@@ -20,6 +20,9 @@
 #
 # Author: David Cantrell <dcantrell at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import logging
 logging.basicConfig(level=logging.DEBUG)
 log = logging.getLogger("bugzilla")
diff --git a/scripts/makeupdates b/scripts/makeupdates
index 3fecebb..b288bc0 100755
--- a/scripts/makeupdates
+++ b/scripts/makeupdates
@@ -21,6 +21,9 @@
 #
 # Author: David Cantrell <dcantrell at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import os
 import shutil
 import subprocess
diff --git a/tests/dracut_tests/parse-kickstart_test.py b/tests/dracut_tests/parse-kickstart_test.py
index 5d19206..5aff119 100644
--- a/tests/dracut_tests/parse-kickstart_test.py
+++ b/tests/dracut_tests/parse-kickstart_test.py
@@ -16,7 +16,10 @@
 # with the express permission of Red Hat, Inc.
 #
 # Author(s): Brian C. Lane <bcl at redhat.com>
-#
+
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import os
 import unittest
 import tempfile
diff --git a/tests/gettext/gettext_potfiles.py b/tests/gettext/gettext_potfiles.py
index 480abbc..6dd9674 100755
--- a/tests/gettext/gettext_potfiles.py
+++ b/tests/gettext/gettext_potfiles.py
@@ -1,5 +1,8 @@
 #!/usr/bin/python3
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import os, sys, subprocess
 
 # The xpath in this file is simple enough that Python's built-in
diff --git a/tests/glade/accelerators/check_accelerators.py b/tests/glade/accelerators/check_accelerators.py
index 26b4159..ab87ec1 100755
--- a/tests/glade/accelerators/check_accelerators.py
+++ b/tests/glade/accelerators/check_accelerators.py
@@ -17,6 +17,9 @@
 #
 # Author: David Shea <dshea at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import sys
 import argparse
 import re
diff --git a/tests/glade/format_string/check_format_string.py b/tests/glade/format_string/check_format_string.py
index b8833b5..b730a94 100755
--- a/tests/glade/format_string/check_format_string.py
+++ b/tests/glade/format_string/check_format_string.py
@@ -29,6 +29,9 @@
 strings are allowable within glade.
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import sys
 import argparse
 import re
diff --git a/tests/glade/icons/check_icons.py b/tests/glade/icons/check_icons.py
index e73c9ad..bfeac6d 100755
--- a/tests/glade/icons/check_icons.py
+++ b/tests/glade/icons/check_icons.py
@@ -21,6 +21,9 @@
 Check that all icons referenced from glade files are valid in the gnome icon theme.
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import argparse
 import sys
 
diff --git a/tests/glade/markup/check_markup.py b/tests/glade/markup/check_markup.py
index d437384..ba639da 100755
--- a/tests/glade/markup/check_markup.py
+++ b/tests/glade/markup/check_markup.py
@@ -23,6 +23,9 @@
 valid markup.
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import sys
 import argparse
 
diff --git a/tests/glade/pw_visibility/check_invisible_char.py b/tests/glade/pw_visibility/check_invisible_char.py
index 2eaaa96..72d8486 100755
--- a/tests/glade/pw_visibility/check_invisible_char.py
+++ b/tests/glade/pw_visibility/check_invisible_char.py
@@ -24,6 +24,9 @@
 The invisible char is often non-ASCII and sometimes that gets clobbered.
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import argparse
 import sys
 
diff --git a/tests/glade/pw_visibility/check_pw_visibility.py b/tests/glade/pw_visibility/check_pw_visibility.py
index 6c5f115..f48f875 100755
--- a/tests/glade/pw_visibility/check_pw_visibility.py
+++ b/tests/glade/pw_visibility/check_pw_visibility.py
@@ -24,6 +24,9 @@
 
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import argparse
 import sys
 
diff --git a/tests/glade/viewport/check_viewport.py b/tests/glade/viewport/check_viewport.py
index 16480d3..bd9d771 100755
--- a/tests/glade/viewport/check_viewport.py
+++ b/tests/glade/viewport/check_viewport.py
@@ -24,6 +24,9 @@
 to add an extra layer.
 """
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import argparse
 import sys
 
diff --git a/tests/gui/outside/__init__.py b/tests/gui/outside/__init__.py
index 0ab332b..3eba8d9 100644
--- a/tests/gui/outside/__init__.py
+++ b/tests/gui/outside/__init__.py
@@ -17,6 +17,9 @@
 #
 # Author: Chris Lumens <clumens at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 __all__ = ["Creator", "OutsideMixin"]
 
 from blivet.size import MiB
diff --git a/tests/lib/translatepo.py b/tests/lib/translatepo.py
index f431618..56b6f01 100644
--- a/tests/lib/translatepo.py
+++ b/tests/lib/translatepo.py
@@ -22,6 +22,9 @@
 # in the po directory, so no gettext compilation or LC_MESSAGES directories are
 # necessary.
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 import os
 import locale
 import re
diff --git a/tests/pyanaconda_tests/iutil_test.py b/tests/pyanaconda_tests/iutil_test.py
index cee03ab..ad0bc82 100644
--- a/tests/pyanaconda_tests/iutil_test.py
+++ b/tests/pyanaconda_tests/iutil_test.py
@@ -19,6 +19,9 @@
 # Red Hat Author(s): Vratislav Podzimek <vpodzime at redhat.com>
 #                    Martin Kolman <mkolman at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 from pyanaconda import iutil
 import unittest
 import os
diff --git a/tests/pyanaconda_tests/ks_version_test.py b/tests/pyanaconda_tests/ks_version_test.py
index 4041d6b..d0b640e 100644
--- a/tests/pyanaconda_tests/ks_version_test.py
+++ b/tests/pyanaconda_tests/ks_version_test.py
@@ -16,6 +16,10 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # Author: Chris Lumens <clumens at redhat.com>
+
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 from mock import Mock
 import unittest
 import os
diff --git a/tests/pyanaconda_tests/simpleconfig_test.py b/tests/pyanaconda_tests/simpleconfig_test.py
index 7da31db..c40b69e 100644
--- a/tests/pyanaconda_tests/simpleconfig_test.py
+++ b/tests/pyanaconda_tests/simpleconfig_test.py
@@ -18,6 +18,9 @@
 #
 # Red Hat Author(s): Brian C. Lane <bcl at redhat.com>
 
+# Ignore any interruptible calls
+# pylint: disable=interruptible-system-call
+
 from pyanaconda.simpleconfig import SimpleConfigFile
 from pyanaconda import simpleconfig
 import unittest


-- 
To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/865e2166328b02dc443a3c346a53667ca0181db9


More information about the anaconda-patches mailing list