[PATCH 1/2] Log the reason if GUI import fails (#1229747)

Brian C. Lane bcl at redhat.com
Wed Jun 17 22:11:11 UTC 2015


On Wed, Jun 17, 2015 at 08:49:00AM -0400, Anne Mulhern wrote:
> 
> 
> 
> 
> ----- Original Message -----
> > From: "Martin Kolman" <mkolman at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Tuesday, June 16, 2015 12:23:09 PM
> > Subject: [PATCH 1/2] Log the reason if GUI import fails (#1229747)
> > 
> > Log the exception that caused the import to fail.
> > 
> > Related: rhbz#1229747
> > Signed-off-by: Martin Kolman <mkolman at redhat.com>
> > ---
> >  initial_setup/__main__.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/initial_setup/__main__.py b/initial_setup/__main__.py
> > index 06b6ea5..642e93c 100644
> > --- a/initial_setup/__main__.py
> > +++ b/initial_setup/__main__.py
> > @@ -108,7 +108,7 @@ if mode == "gui":
> >          log.debug("trying to import GUI")
> >          import gui
> >      except ImportError:
> > -        log.error("GUI import failed, falling back to TUI")
> > +        log.exception("GUI import failed, falling back to TUI")
> >          mode = "tui"
> >  
> >  if mode == "gui":
> > --
> > 2.4.2
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> In itself this looks fine to me, but I remember that long ago the presence of
> tracebacks in the blivet log caused problems for some other tools that searched
> for tracebacks as a sign of failure. It hindered some of bcl's building for a while.
> 
> See blivet commit f3ff0a62b029525c83253b07800edaf2868c67cd and lorax commit
> 29de1d43a5f9f2574d94824bdc0dd45742763abb for some details.

This import is only running after the install reboots, so I don't think
it will be a problem. The issue you remembered was with
livemedia-creator running anaconda.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list