[master 2/2] Deprecate some little-used devicetree lookup methods.

dwlehman installerbot-noreply at redhat.com
Wed Jun 17 21:17:23 UTC 2015


From: David Lehman <dlehman at redhat.com>

---
 blivet/devicetree.py | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/blivet/devicetree.py b/blivet/devicetree.py
index 3349569..ff7d8ee 100644
--- a/blivet/devicetree.py
+++ b/blivet/devicetree.py
@@ -22,6 +22,7 @@
 
 import os
 import re
+import warnings
 
 from gi.repository import BlockDev as blockdev
 
@@ -695,8 +696,15 @@ def getDevicesBySerial(self, serial, incomplete=False, hidden=False):
             :param bool hidden: include hidden devices in search
             :returns: all matching devices found
             :rtype: list of :class:`~.devices.Device`
+
+            .. deprecated:: 1.7
+                Use ``[d for d in dt.devices if d.serial == serial]`` instead.
+
         """
         log_method_call(self, serial=serial, incomplete=incomplete, hidden=hidden)
+        warnings.warn("DeviceTree.getDevicesBySerial will be removed in a "
+                      "future version.",
+                      DeprecationWarning)
         devices = self._filterDevices(incomplete=incomplete, hidden=hidden)
         retval = []
         for device in devices:
@@ -779,8 +787,15 @@ def getDevicesByType(self, device_type, incomplete=False, hidden=False):
             :param bool hidden: include hidden devices in search
             :returns: all matching device found
             :rtype: list of :class:`~.devices.Device`
+
+            .. deprecated:: 1.7
+                Use ``[d for d in dt.devices if d.type == dtype]`` instead.
+
         """
         log_method_call(self, device_type=device_type, incomplete=incomplete, hidden=hidden)
+        warnings.warn("DeviceTree.getDevicesByType will be removed in a "
+                      "future version.",
+                      DeprecationWarning)
         devices = self._filterDevices(incomplete=incomplete, hidden=hidden)
         result = [d for d in devices if d.type == device_type]
         log_method_return(self, [r.name for r in result])
@@ -794,8 +809,15 @@ def getDevicesByInstance(self, device_class, incomplete=False, hidden=False):
             :param bool hidden: include hidden devices in search
             :returns: all matching device found
             :rtype: list of :class:`~.devices.Device`
+
+            .. deprecated:: 1.7
+                Use ``[d for d in dt.devices if isinstance(dev, cls)]`` instead.
+
         """
         log_method_call(self, device_class=device_class, incomplete=incomplete, hidden=hidden)
+        warnings.warn("DeviceTree.getDevicesByInstance will be removed in a "
+                      "future version.",
+                      DeprecationWarning)
         devices = self._filterDevices(incomplete=incomplete, hidden=hidden)
         result = [d for d in devices if isinstance(d, device_class)]
         log_method_return(self, [r.name for r in result])


-- 
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/d2ce0e6a0832fedb1332d4844275fdbe9fa4e016


More information about the anaconda-patches mailing list