[blivet][rhel7-branch] Make sure to add hyperPAV aliases to dasd.conf (#1031589)

Samantha N. Bueno sbueno+anaconda at redhat.com
Mon Jun 15 23:29:44 UTC 2015


On Mon, Jun 15, 2015 at 02:48:13PM -0400, Samantha N. Bueno wrote:
> On Mon, Jun 15, 2015 at 11:19:26AM -0700, Brian C. Lane wrote:
> > On Mon, Jun 15, 2015 at 01:19:02PM -0400, Samantha N. Bueno wrote:
> > > On Mon, Jun 15, 2015 at 09:27:45AM -0700, Brian C. Lane wrote:
> > >  
> > > > > +            with open(aliasfile, "r") as falias:
> > > > > +                alias = falias.read().strip()
> > > > 
> > > > What's in alias? Maybe a comment about the conditions that need to be
> > > > met would be good here (eg. alias present and contains anything).
> > > 
> > > It's either a 0 or a 1, depending on whether or not it is an alias (1).
> > > But yeah, I'll definitely add a comment.
> > 
> > Ah, ok. Don't you want to test the result against "0" then?
> 
> Hm, not sure that I follow. I only want to write to dasd.conf if alias
> is 1 (device is an alias). This is because the non-alias (0) DASDs will
> already have entries in dasd.conf by this point; I don't want to create
> duplicate entries.

Just for clarification, discussed with bcl in irc; I've applied his
suggestion to test the result against 0.

Samantha


More information about the anaconda-patches mailing list