[master 1/1] Use len of set to check for duplicates in list of packages.
atodorov
installerbot-noreply at redhat.com
Thu Jun 11 12:54:03 UTC 2015
From: Alexander Todorov <atodorov at redhat.com>
Resolves: #154.
Checking for equality of the two lists was a mistake, since
the order of the list generated from the set is undefined.
---
tests/devices_test/device_packages_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/devices_test/device_packages_test.py b/tests/devices_test/device_packages_test.py
index 3e3863f..c613800 100644
--- a/tests/devices_test/device_packages_test.py
+++ b/tests/devices_test/device_packages_test.py
@@ -20,7 +20,7 @@ def testPackages(self):
packages = luks.packages
# no duplicates in list of packages
- self.assertListEqual(packages, list(set(packages)))
+ self.assertEqual(len(packages), len(set(packages)))
# several packages that ought to be included are
for package in dev1.packages + dev2.packages + dev.packages:
--
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/443874df07a3c3ed8d9e075b25e5f93c1de0128b
More information about the anaconda-patches
mailing list