[PATCH 4/8] Fix issues with advanced storage searching.

David Shea dshea at redhat.com
Fri Jun 5 13:15:23 UTC 2015


On 06/04/2015 07:49 PM, Brian C. Lane wrote:
> On Thu, Jun 04, 2015 at 03:57:40PM -0400, David Shea wrote:
>>       def _port_equal(self, device):
>>           active = self._portCombo.get_active_text()
>> -        if active and hasattr(device, "node"):
>> -            return device.node.port == active
>> +        if active:
>> +            if hasattr(device, "node"):
>> +                return device.node.port == int(active)
> I think this needs a ValueError exception block since it is user entered
> text.
>
>

It shouldn't, the port number comes out of a combobox that we populate.


More information about the anaconda-patches mailing list