[RHEL 7.2/PATCH] Update Active On Vol Create Cancel (rhbz#1168656)

Vratislav Podzimek vpodzime at redhat.com
Wed Jun 3 06:26:38 UTC 2015


On Tue, 2015-06-02 at 14:15 -0400, Robert Marshall wrote:
> The "Update Settings" button in the custom partition screen would
> activate after a user attempted to create a new volume and then
> pressed the cancel button. This patches removes the double event
> handler which was always setting the button to active no matter
> what action happened in the dialog.
> 
> Resolves: rhbz#1168656
> ---
>  pyanaconda/ui/gui/spokes/custom.glade | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade
> index 2cf6e70..229e554 100644
> --- a/pyanaconda/ui/gui/spokes/custom.glade
> +++ b/pyanaconda/ui/gui/spokes/custom.glade
> @@ -815,7 +815,7 @@
>                                                          <property name="can_focus">False</property>
>                                                          <property name="model">containerStore</property>
>                                                          <signal name="changed" handler="on_container_changed" swapped="no"/>
> -                                                        <signal name="changed" handler="on_value_changed" swapped="no"/>
> +                                                        <!-- signal name="changed" handler="on_value_changed" swapped="no"/ -->
>                                                          <child>
>                                                            <object class="GtkCellRendererText" id="descRenderer"/>
>                                                            <attributes>
This would need some testing, but I think we need to do a bit more. The
on_value_changed callback makes the "Update Settings" button sensitive
which means that if "Done" or some device selector is clicked, changes
are saved. That AFAICT needs to happen if container is actually changed.
So we should remove the on_value_changed callback, but we need to make
sure 'self._applyButton.set_sensitive(True)' is called in the
on_container_changed callback unless user chose to create a new
container and hit the "Cancel" button.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list