[PATCH 1/2] Fix a couple more pylint problems in the s390 code.
Chris Lumens
clumens at redhat.com
Tue Jun 2 15:15:45 UTC 2015
---
pyanaconda/ui/gui/spokes/advstorage/zfcp.py | 5 -----
tests/pylint/pylint-false-positives | 1 +
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/advstorage/zfcp.py b/pyanaconda/ui/gui/spokes/advstorage/zfcp.py
index d974474..1d7ab46 100644
--- a/pyanaconda/ui/gui/spokes/advstorage/zfcp.py
+++ b/pyanaconda/ui/gui/spokes/advstorage/zfcp.py
@@ -23,8 +23,6 @@ from pyanaconda.ui.gui import GUIObject
from pyanaconda.ui.gui.utils import gtk_action_nowait
from gi.repository import BlockDev as blockdev
-from blivet.zfcp import ZFCPDevice
-
__all__ = ["ZFCPDialog"]
class ZFCPDialog(GUIObject):
@@ -90,10 +88,7 @@ class ZFCPDialog(GUIObject):
self._set_configure_sensitive(False)
self._deviceEntry.set_sensitive(False)
- # Make a zFCP object with some dummy credentials so we can validate our
- # actual input
self._conditionNotebook.set_current_page(1)
- dev = ZFCPDevice("0.0.0000", "0x0000000000000000", "0x0000000000000000")
# below really, really is ugly and needs to be re-factored, but this
# should give a good base idea as far as expected behavior should go
try:
diff --git a/tests/pylint/pylint-false-positives b/tests/pylint/pylint-false-positives
index 03b7ccb..8eb467a 100644
--- a/tests/pylint/pylint-false-positives
+++ b/tests/pylint/pylint-false-positives
@@ -3,6 +3,7 @@
^E0611:[ 0-9]*,[0-9]*: No name '_isys' in module 'pyanaconda'$
^E0611:[ 0-9]*,[0-9]*:.*: No name '_isys' in module 'pyanaconda'$
^E0712:[ 0-9]*,[0-9]*:.*: Catching an exception which doesn't inherit from BaseException: GError$
+^E0712:[ 0-9]*,[0-9]*:.*: Catching an exception which doesn't inherit from BaseException: S390Error$
PyGIDeprecationWarning: GLib\..* is deprecated
PyGIDeprecationWarning: GObject\..* is deprecated
obj = getattr\(parent, name\)$
--
2.2.2
More information about the anaconda-patches
mailing list