[master 13/30] Remove "is Unicode" tests (#1014220)

M4rtinK installerbot-noreply at redhat.com
Mon Jun 1 14:04:30 UTC 2015


From: Martin Kolman <mkolman at redhat.com>

All strings are Unicode strings in Python, so remove
tests that check if a string is Unicode or not.
---
 tests/pyanaconda_tests/iutil_test.py | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/tests/pyanaconda_tests/iutil_test.py b/tests/pyanaconda_tests/iutil_test.py
index e27516e..95454f0 100644
--- a/tests/pyanaconda_tests/iutil_test.py
+++ b/tests/pyanaconda_tests/iutil_test.py
@@ -592,17 +592,9 @@ class O(object):
     def strip_accents_test(self):
         """Test strip_accents."""
 
-        # string needs to be Unicode,
-        # otherwise TypeError is raised
-        with self.assertRaises(TypeError):
-            iutil.strip_accents("")
-        with self.assertRaises(TypeError):
-            iutil.strip_accents("abc")
-        with self.assertRaises(TypeError):
-            iutil.strip_accents("ěščřžýáíé")
-
-        # empty Unicode string
+        # empty string
         self.assertEquals(iutil.strip_accents(u""), u"")
+        self.assertEquals(iutil.strip_accents(""), "")
 
         # some Czech accents
         self.assertEquals(iutil.strip_accents(u"ěščřžýáíéúů"), u"escrzyaieuu")
@@ -671,17 +663,6 @@ class O(object):
     def to_ascii_test(self):
         """Test _toASCII."""
 
-        # works with strings only, chokes on Unicode strings
-        with self.assertRaises(ValueError):
-            iutil._toASCII(u" ")
-        with self.assertRaises(ValueError):
-            iutil._toASCII(u"ABC")
-        with self.assertRaises(ValueError):
-            iutil._toASCII(u"Heizölrückstoßabdämpfung")
-
-        # but empty Unicode string is fine :)
-        iutil._toASCII(u"")
-
         # check some conversions
         self.assertEqual(iutil._toASCII(""), "")
         self.assertEqual(iutil._toASCII(" "), " ")


-- 
To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/776ba237c4b3524fc09923b118a3743b3f2c1f0d


More information about the anaconda-patches mailing list