[rhinstaller/anaconda/pulls/265 master] Add few docs and improvement in check_ip_address

vpodzime installerbot-noreply at redhat.com
Fri Jul 31 13:47:04 UTC 2015


> @@ -116,8 +126,11 @@ def sanityCheckHostname(hostname):
>  
>      return (True, "")
>  
> -# Return a list of IP addresses for all active devices.
>  def getIPs():
> +    """ Return a list of IP addresses for all active devices.
> +
> +        :return: list of IP addresses

I think this only duplicates the description. Either drop it and make the docstring one-line or replace it with ``:rtype:`` which would be more interesting here, I'd say.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/265#discussion_r35974343


More information about the anaconda-patches mailing list