[master 1/4] Run remove and append callbacks when replacing a parent.

vpodzime installerbot-noreply at redhat.com
Wed Jul 29 07:36:01 UTC 2015


This is either wrong or really confusing. The docstring of this method says: "*Replace the first instance of x with y, bypassing callbacks.*" and was intentionally not implemented as ``self.remove()`` followed by ``self.add()`` to ensure exactly that. So either the docstring and the implementation needs to change or any problematic call of this method should be replaced with ``remove(); add()``.

-- 
To view this comment on github, visit https://github.com/dwlehman/blivet/commit/426e1e45eb5fe72f70bebbef4faead22b1e5e711#commitcomment-12413911


More information about the anaconda-patches mailing list