[PATCH] Clean up the temporary pools virt-install makes.

David Shea dshea at redhat.com
Mon Jul 27 20:48:13 UTC 2015


On 07/27/2015 12:35 PM, Chris Lumens wrote:
> For a directory path like /var/tmp/kstest-whatever/disks, virt-install is
> making two storage pools:  kstest-whatever, and disks-XX.  It also doesn't
> get rid of these pools after it shuts down, and you will eventually end up
> with a giant pile of them clogging everything up.
>
> So there are two fixes here to do the clean up:
>
> (1) We know the name of the first pool associated with a single test.  It's
> the temporary directory being created in /var/tmp.  So just use the virsh
> commands to destroy that pool.
>
> (2) We don't know (and can't figure out) the name of the disks-XX pool.
> However, that one is only being created because of the subdirectory that disk
> images are being stored in.  So instead store them in /var/tmp/kstest-whatever
> and do not create the disks subdirectory any more.
> ---
>   tests/kickstart_tests/basic-ostree.sh     | 4 ++--
>   tests/kickstart_tests/btrfs-1.sh          | 2 +-
>   tests/kickstart_tests/btrfs-2.sh          | 2 +-
>   tests/kickstart_tests/driverdisk-disk.sh  | 6 +++---
>   tests/kickstart_tests/encrypt-device.sh   | 2 +-
>   tests/kickstart_tests/functions.sh        | 6 +++---
>   tests/kickstart_tests/hostname.sh         | 2 +-
>   tests/kickstart_tests/kstest-runner       | 6 ++++--
>   tests/kickstart_tests/raid-1.sh           | 8 ++++----
>   tests/kickstart_tests/run_one_ks.sh       | 9 ++-------
>   tests/kickstart_tests/tmpfs-fixed_size.sh | 2 +-
>   11 files changed, 23 insertions(+), 26 deletions(-)

Looks fine.


More information about the anaconda-patches mailing list