[rhinstaller/anaconda/pulls/231 master] Wait forever for kickstarts on CDROM (#1168902)

vpodzime installerbot-noreply at redhat.com
Wed Jul 22 07:02:51 UTC 2015


> @@ -19,6 +19,12 @@ case "${kickstart%%:*}" in
>              when_diskdev_appears "$ksdev" \
>                  fetch-kickstart-disk \$env{DEVNAME} "$kspath"
>          fi
> +        # "cdrom:" also means "wait forever for kickstart" because rhbz#1168902
> +        if [ "$kstype" = "cdrom" ]; then
> +            # if we reset main_loop to 0 every loop, we never hit the timeout..
> +            jobfile="$hookdir/initqueue/finished/wait-forever-for-ks-cdrom.sh"
> +            echo "main_loop=0" > "$jobfile"

I don't now how exactly the ``finished`` guards work, but where does ``main_loop`` come from and if it is a variable, shouldn't the condition be ``$main_loop=0``? Unless I'm missing some big thing here, the comment needs to be extended a bit.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/231#discussion_r35186270


More information about the anaconda-patches mailing list