[master 1/1] Fix crash when protocol combobox changed item
jkonecny12
installerbot-noreply at redhat.com
Mon Jul 20 14:42:58 UTC 2015
From: Jiri Konecny <jkonecny at redhat.com>
The method on_repoUrl_changed in Source spoke is now called by Gtk.Entry
and Gtk.ComboBoxText too. This caused crash in a method depending on
Gtk.Entry but sometimes gets ComboBoxText instead.
---
pyanaconda/ui/gui/spokes/source.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/source.py b/pyanaconda/ui/gui/spokes/source.py
index d909ec9..67c19bb 100644
--- a/pyanaconda/ui/gui/spokes/source.py
+++ b/pyanaconda/ui/gui/spokes/source.py
@@ -1415,7 +1415,9 @@ def on_repoNameEntry_changed(self, entry):
self._repoChecks[name].name_check.update_check_status()
def on_repoUrl_changed(self, editable, data=None):
- """ proxy url or protocol changed
+ """ Additional repository url or protocol changed.
+
+ Note: variable editable could be Gtk.Entry or Gtk.ComboBoxText here.
"""
itr = self._repoSelection.get_selected()[1]
if not itr:
@@ -1432,7 +1434,7 @@ def on_repoUrl_changed(self, editable, data=None):
self._repoChecks[repo.name].url_check.update_check_status()
# Check for and remove a URL prefix that matches the protocol dropdown
- self._removeUrlPrefix(editable, self._repoProtocolComboBox, self.on_repoUrl_changed)
+ self._removeUrlPrefix(self._repoUrlEntry, self._repoProtocolComboBox, self.on_repoUrl_changed)
def on_repoMirrorlistCheckbox_toggled(self, *args):
""" mirror state changed
--
To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/0afab81794edcc81fee006943142b6a617a6021d
More information about the anaconda-patches
mailing list