[master 5/6] dd-refactor: new driver_updates.py + tests

wgwoods installerbot-noreply at redhat.com
Wed Jul 8 18:21:29 UTC 2015


In reply to line 354 of dracut/driver_updates.py:

> This will return the shortname for anything with a simlink, where below it is only returning it for /dev/ -- maybe use basename for both cases and remove the /dev/ check?

the `islink` case is there for things like `/dev/disk/by-label/OEMDRV` or `/dev/block/8:3` (although maybe I could just use `os.path.realpath` to resolve any symlinks first..)

After that, though, we don't want `os.path.basename` because of things like `/dev/cciss/c0d0` and `/dev/i2o/hda` - the kernel's `disk_name` for those devices is actually `cciss/c0d0` and `i2o/hda`, and especially the latter would be confusing if you also have a `/dev/hda`.

-- 
To view this comment on github, visit https://github.com/wgwoods/anaconda/commit/d2698c0e08d29b5754db8e7a42e1dfc7bd79e6aa#commitcomment-12068208


More information about the anaconda-patches mailing list