[PATCH 1/2] Pass multiple args to runone in run_kickstart_tests.sh
Vratislav Podzimek
vpodzime at redhat.com
Fri Jan 30 06:59:54 UTC 2015
On Thu, 2015-01-29 at 20:39 -0800, Brian C. Lane wrote:
> Only quote the args, not the command, so that they get passed to
> livemedia-creator as one group. Use eval so that bash doesn't eat the
> kittens.
> ---
> tests/kickstart_tests/run_kickstart_tests.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kickstart_tests/run_kickstart_tests.sh b/tests/kickstart_tests/run_kickstart_tests.sh
> index 9fbf67f..e977b4a 100755
> --- a/tests/kickstart_tests/run_kickstart_tests.sh
> +++ b/tests/kickstart_tests/run_kickstart_tests.sh
> @@ -84,10 +84,10 @@ runone() {
>
> kargs=$(kernel_args)
> if [[ ${kargs} != "" ]]; then
> - kargs="--kernel-args ${kargs}"
> + kargs="--kernel-args \"$kargs\""
> fi
>
> - livemedia-creator ${kargs} \
> + eval livemedia-creator ${kargs} \
> --make-disk \
> --iso "${IMAGE}" \
> --ks ${ksfile} \
These both look good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list