[PATCH 2/2] Hook formatByDefault back up to the storage spoke.

Adam Williamson awilliam at redhat.com
Thu Jan 22 21:56:00 UTC 2015


On Thu, 2015-01-22 at 16:54 -0500, David Shea wrote:
> On 01/22/2015 04:48 PM, David Shea wrote:
> > formatByDefault does not check /
> 
> That's a lie, it's just hardcoded into a conditional instead of 
> listed in that list

Right. The reason (I figure) is that, for obvious reasons, we don't 
want to do the 'startswith' check for / , because it'd match 
everything. Hence the split, so we can do the 'startswith' check for 
things-other-than-root, and only do an exact match check for root.

> > , and it was always returning false anyway since format.mountpoint 
> > isn't set here. So this needs some work.
> 
> but that's still true.



Heh, didn't check it that far, I just eyeballed it :)
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net



More information about the anaconda-patches mailing list