[blivet][master] pylint-inspired fixes
Samantha N. Bueno
sbueno+anaconda at redhat.com
Wed Jan 21 13:45:54 UTC 2015
On Wed, Jan 21, 2015 at 11:50:33AM +0100, Vratislav Podzimek wrote:
> These things were reported by pylint when I tried to clean everything up before
> starting to port blivet to libblockdev. One issue still remains:
>
> ************* Module blivet/formats/fs.py
> blivet/formats/fs.py:1499: [W0201(attribute-defined-outside-init), NoDevFS._setDevice] Attribute '_device' defined outside __init__
>
> but I don't want to create a conflict with mulhern's patches for the NoDevFS class.
>
> Vratislav Podzimek (3):
> Disable pylint check for cached LVM data in more places
> Define the _device attribute in constructor
> Do not create lambda over and over in a cycle
These all three look ok to me.
> blivet/devicetree.py | 4 ++--
> blivet/formats/fs.py | 4 ++++
> scripts/makebumpver | 3 ++-
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> --
> 2.1.0
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
More information about the anaconda-patches
mailing list