[blivet:master 10/21] Do not set self.exists to True in TmpFS.__init__().

Anne Mulhern amulhern at redhat.com
Tue Jan 20 19:30:46 UTC 2015





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, January 20, 2015 1:25:56 PM
> Subject: Re: [blivet:master 10/21] Do not set self.exists to True in	TmpFS.__init__().
> 
> On 01/15/2015 12:39 PM, mulhern wrote:
> > This behavior is implemented in NoDevFS.__init__().
> >
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >   blivet/formats/fs.py | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
> > index 158b7c4..74c469e 100644
> > --- a/blivet/formats/fs.py
> > +++ b/blivet/formats/fs.py
> > @@ -1544,7 +1544,6 @@ class TmpFS(NoDevFS):
> >
> >       def __init__(self, **kwargs):
> >           NoDevFS.__init__(self, **kwargs)
> > -        self.exists = True
> >           self._device = "tmpfs"
> >
> >           # according to the following Kernel ML thread:
> >
> 
> Am I right to think that an active status is equivalent to existence for
> tmpfs?
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

I do not know.

If you are arguing that a tmpfs does not exist unless and until it is mounted,
I would say that that makes some sense to me.

But what I'm doing here is just getting rid of another variant of a "pointless override",
not actually changing any behavior.

- mulhern


More information about the anaconda-patches mailing list