[pykickstart][rhel6-branch] Add clearpart --cdl option. (#1182624)
Samantha N. Bueno
sbueno+anaconda at redhat.com
Mon Jan 19 15:40:21 UTC 2015
On Mon, Jan 19, 2015 at 10:34:50AM -0500, Chris Lumens wrote:
> > On Thu, Jan 15, 2015 at 01:59:03PM -0500, Samantha N. Bueno wrote:
> > > --- a/pykickstart/commands/clearpart.py
> > > +++ b/pykickstart/commands/clearpart.py
> > > @@ -35,6 +35,7 @@ class FC3_ClearPart(KickstartCommand):
> > > self.drives = kwargs.get("drives", [])
> > > self.initAll = kwargs.get("initAll", False)
> > > self.type = kwargs.get("type", None)
> > > + self.cdl = kwargs.get("cdl", False)
> >
> > Normally this would go into a new class instead of modifying an existing
> > one, but I'm not sure what chris wants for rhel6 so you should see what
> > he says.
>
> Yep, you're right. Adding this to FC3_ClearPart means that support for
> this option was added in FC3 and that all Fedoras after that point
> supported it. This is not the case.
>
> Thus it'll have to be in a new RHEL6_ClearPart class that inherits from
> FC3_ClearPart. master will also have to get the same patch so that
> future versions of pykickstart know this too.
That makes sense; thanks for the clarification. I'll post follow-up
patches in a bit then.
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
More information about the anaconda-patches
mailing list