[blivet-gui:master 0/9] Pylint patches

Vojtěch Trefný vtrefny at redhat.com
Wed Jan 14 18:29:49 UTC 2015


That was quick. Big thanks!

I've added you to github as a collaborator so you should be able to push 
the changes.

Dne 14.1.2015 v 17:53 mulhern napsal(a):
> _Please_ note warning below.
>
> Initial setup and some fixes. Attached below are remaining pylint errors.
> Most are just unused-argument which are probably intentionally unused, due to
> GUI interface requirements and probably just need to be suppressed.
I know about this, I'll try to find way how to make Gtk signals not to 
add information I don't need.

> A few are no-member; maybe set_margin_start should be set_margin_left, but
> I am not sure.
set_margin_start is a new method in Gtk 3.12 (but I should probably 
change it to set_margin_left because 3.12 is only in Fedora 21).
>
> It is customary to put this stuff in tests/pylint subdirectory, so I did.
> I had to remove tests entry from .gitignore. Please make sure not to kill
> your local private tests directory if such a thing exists, by applying
> these patches. Thanks.
>
>
> ************* Module blivetgui/actions_toolbar.py
> blivetgui/actions_toolbar.py:152: [W0613(unused-argument), ActionsToolbar.on_delete_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:158: [W0613(unused-argument), ActionsToolbar.on_add_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:164: [W0613(unused-argument), ActionsToolbar.on_edit_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:170: [W0613(unused-argument), ActionsToolbar.on_umount_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:176: [W0613(unused-argument), ActionsToolbar.on_decrypt_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:182: [W0613(unused-argument), ActionsToolbar.on_apply_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:188: [W0613(unused-argument), ActionsToolbar.on_clear_clicked] Unused argument 'button'
> blivetgui/actions_toolbar.py:194: [W0613(unused-argument), ActionsToolbar.on_undo_clicked] Unused argument 'button'
> ************* Module blivetgui/dialogs/edit_dialog.py
> blivetgui/dialogs/edit_dialog.py:164: [W0613(unused-argument), PartitionEditDialog.on_format_changed] Unused argument 'event'
> blivetgui/dialogs/edit_dialog.py:382: [W0613(unused-argument), LVMEditDialog.on_cell_toggled] Unused argument 'toggle'
> blivetgui/dialogs/edit_dialog.py:385: [W0613(unused-argument), LVMEditDialog.on_cell_radio_toggled] Unused argument 'toggle'
> ************* Module blivetgui/list_partitions.py
> blivetgui/list_partitions.py:77: [E1101(no-member), ListPartitions.__init__] Instance of 'Label' has no 'set_margin_start' member
> blivetgui/list_partitions.py:78: [E1101(no-member), ListPartitions.__init__] Instance of 'Label' has no 'set_margin_end' member
> blivetgui/list_partitions.py:863: [W0613(unused-argument), ListPartitions.quit] Unused argument 'widget'
> blivetgui/list_partitions.py:863: [W0613(unused-argument), ListPartitions.quit] Unused argument 'event'
> ************* Module blivetgui/dialogs/other_dialogs.py
> blivetgui/dialogs/other_dialogs.py:187: [W0613(unused-argument), KickstartSelectDevicesDialog.on_cell_toggled] Unused argument 'event'
> blivetgui/dialogs/other_dialogs.py:214: [W0613(unused-argument), KickstartSelectDevicesDialog.on_boot_changed] Unused argument 'event'
> ************* Module blivetgui/dialogs/add_dialog.py
> blivetgui/dialogs/add_dialog.py:264: [W0613(unused-argument), SizeChooserArea.get_size_precision] Unused argument 'unit'
> blivetgui/dialogs/add_dialog.py:683: [W0613(unused-argument), AddDialog.on_raid_type_changed] Unused argument 'event'
> blivetgui/dialogs/add_dialog.py:807: [W0613(unused-argument), AddDialog.on_cell_toggled] Unused argument 'event'
> blivetgui/dialogs/add_dialog.py:983: [W0613(unused-argument), AddDialog.on_md_type_changed] Unused argument 'event'
> blivetgui/dialogs/add_dialog.py:1129: [W0613(unused-argument), AddDialog.on_devices_combo_changed] Unused argument 'event'
> blivetgui/dialogs/add_dialog.py:1253: [W0613(unused-argument), AddDialog.on_ok_clicked] Unused argument 'event'
> ************* Module blivetgui/devicevisualization/device_canvas.py
> blivetgui/devicevisualization/device_canvas.py:390: [W0613(unused-argument), DeviceCanvas.button_press_event] Unused argument 'darea'
> ************* Module blivetgui/actions_menu.py
> blivetgui/actions_menu.py:129: [W0613(unused-argument), ActionsMenu.on_add_item] Unused argument 'event'
> blivetgui/actions_menu.py:134: [W0613(unused-argument), ActionsMenu.on_delete_item] Unused argument 'event'
> blivetgui/actions_menu.py:139: [W0613(unused-argument), ActionsMenu.on_edit_item] Unused argument 'event'
> blivetgui/actions_menu.py:144: [W0613(unused-argument), ActionsMenu.on_umount_item] Unused argument 'event'
> blivetgui/actions_menu.py:149: [W0613(unused-argument), ActionsMenu.on_decrypt_item] Unused argument 'event'
> ************* Module examples/embeded.py
> examples/embeded.py:58: [W0613(unused-argument), SocketWindow.plugged_event] Unused argument 'widget'
> ************* Module blivetgui/main_menu.py
> blivetgui/main_menu.py:256: [W0613(unused-argument), MainMenu.on_about_item] Unused argument 'args'
> blivetgui/main_menu.py:262: [W0613(unused-argument), MainMenu.on_help_item] Unused argument 'args'
> blivetgui/main_menu.py:295: [W0613(unused-argument), MainMenu.on_undo_item] Unused argument 'args'
> blivetgui/main_menu.py:301: [W0613(unused-argument), MainMenu.on_clear_item] Unused argument 'args'
> blivetgui/main_menu.py:307: [W0613(unused-argument), MainMenu.on_apply_item] Unused argument 'args'
> blivetgui/main_menu.py:313: [W0613(unused-argument), MainMenu.on_add_item] Unused argument 'args'
> blivetgui/main_menu.py:319: [W0613(unused-argument), MainMenu.on_delete_item] Unused argument 'args'
> blivetgui/main_menu.py:325: [W0613(unused-argument), MainMenu.on_edit_item] Unused argument 'args'
> blivetgui/main_menu.py:331: [W0613(unused-argument), MainMenu.on_umount_item] Unused argument 'args'
> blivetgui/main_menu.py:337: [W0613(unused-argument), MainMenu.on_decrypt_item] Unused argument 'args'
> blivetgui/main_menu.py:343: [W0613(unused-argument), MainMenu.on_quit_item] Unused argument 'args'
> blivetgui/main_menu.py:349: [W0613(unused-argument), MainMenu.on_reload_item] Unused argument 'args'
> ************* Module blivetgui/processing_window.py
> blivetgui/processing_window.py:112: [W0613(unused-argument), ProcessingActions.on_timeout] Unused argument 'user_data'
>
> mulhern (9):
>    Initial pylint setup.
>    Fix bad indentation.
>    Do not use builtin name format as parameter name.
>    Do not use wildcard import.
>    Move % operator outside translation.
>    Omit needless imports.
>    Omit or hide unused variables and computations.
>    Change relative to absolute imports.
>    Suppress broad-except pylint errors.
>
>   .gitignore                                     |   1 -
>   blivet-gui                                     |   2 +-
>   blivetgui/devicevisualization/device_canvas.py |   2 +-
>   blivetgui/dialogs/edit_dialog.py               |   6 +-
>   blivetgui/list_partitions.py                   |   2 +-
>   blivetgui/main.py                              |   8 +-
>   blivetgui/processing_window.py                 |   4 +-
>   blivetgui/udisks_loop.py                       |   3 -
>   blivetgui/utils.py                             |  16 +-
>   examples/embeded.py                            |   4 +-
>   tests/lib/testlib.sh                           |  37 ++++
>   tests/pylint/intl.py                           |  63 +++++++
>   tests/pylint/pointless-override.py             | 252 +++++++++++++++++++++++++
>   tests/pylint/pylint-false-positives            |   0
>   tests/pylint/pylint-one.sh                     |  33 ++++
>   tests/pylint/runpylint.sh                      | 125 ++++++++++++
>   tests/testenv.sh                               |  13 ++
>   17 files changed, 544 insertions(+), 27 deletions(-)
>   create mode 100644 tests/lib/testlib.sh
>   create mode 100644 tests/pylint/intl.py
>   create mode 100644 tests/pylint/pointless-override.py
>   create mode 100644 tests/pylint/pylint-false-positives
>   create mode 100755 tests/pylint/pylint-one.sh
>   create mode 100755 tests/pylint/runpylint.sh
>   create mode 100644 tests/testenv.sh
>



More information about the anaconda-patches mailing list