[anaconda 1/3] Maximize anaconda instead of running fullscreen (#1164457)

Vratislav Podzimek vpodzime at redhat.com
Wed Jan 14 17:00:09 UTC 2015


On Wed, 2015-01-14 at 09:38 -0500, David Shea wrote:
> On 01/14/2015 02:43 AM, Vratislav Podzimek wrote:
> > On Tue, 2015-01-13 at 17:07 -0500, David Shea wrote:
> >> A fullscreen anaconda is inconvenient when running outside of the
> >> regular installer media, since on Live installs some things are only
> >> configurable in the desktop environment, and on dir and image installs
> >> you might have other things to do while anaconda is running. Instead,
> >> maximize anaconda and use the hide-titlebar-when-maximized property to
> >> hide the titlebar on window manager that support it, which is really
> >> just GNOME.
> >> ---
> >>   pyanaconda/ui/gui/__init__.py | 25 +++++++------------------
> >>   1 file changed, 7 insertions(+), 18 deletions(-)
> >>
> >> diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
> >> index bd6941d..40a7375 100644
> >> --- a/pyanaconda/ui/gui/__init__.py
> >> +++ b/pyanaconda/ui/gui/__init__.py
> >> @@ -271,6 +271,11 @@ class MainWindow(Gtk.Window):
> >>       def __init__(self):
> >>           Gtk.Window.__init__(self)
> >>   
> >> +        # Hide the titlebar when maximized if the window manager allows it.
> >> +        # This makes anaconda look full-screenish but without covering parts
> >> +        # needed to interact with the window manager, like the GNOME top bar.
> >> +        self.set_hide_titlebar_when_maximized(True)
> > So for Xfce, MATE, KDE (not Cinnamon, right?) this means there will be a
> > title bar? Is it an issue? Honestly, I never understood why we fight the
> > title bar in live environments.
> >
> 
> That's correct. Same for initial-setup when running in anything other 
> than metacity.
> 
> I don't know if there's a real reason for fighting the title bar other 
> than tradition, since before live installs there was no reason to 
> interact with anything in the window manager that wasn't anaconda or 
> launched by anaconda. That's still true for non-live installs, and for 
> initial-setup. Live installs and image/dir installs need to allow some 
> interaction with the window manager either because we refuse to 
> configure something in those cases (network connections, language 
> support), or because on image/dir installs we're not the only thing that 
> someone might be doing on their workstation.
> 
> http://blogs.gnome.org/mclasen/2014/01/13/client-side-decorations-continued/ 
> has some discussion on the thinking behind the 
> hide-titlebar-when-maximized property, along with why GNOME application 
> no longer use it. The lack of a close button isn't an issue for 
> anaconda, since we always have a quit button available at the times when 
> a close button would work, and for us a GtkHeaderBar would just mean 
> more wasted vertical space. So for the Workstation install case, 
> hide-titlebar-when-maximized is a pretty good way to keep it possible to 
> interact with the window manager and look a little more GNOME-y while 
> we're at it.
> 
> Outside of GNOME we'll just have to live the life of every other window 
> and have a title bar. Depending on the window manager, that might be 
> necessary in order to unmaximize or move the anaconda window. So for 
> non-GNOME, live/img/dir installs, the title bar might look a little 
> weird at first because we're not used to seeing it, but I think having 
> it is for the best.
> 
> For initial-setup, though, we don't need to allow interaction with the 
> window manager, so maybe leaving the initial-setup window fullscreen 
> would be best. A fullscreen argument to GraphicalUserInterface that 
> initial-setup can set, maybe?
Sounds like a good idea to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list