[blivet][master,rhel7] do not try to install over broken storage

David Lehman dlehman at redhat.com
Fri Jan 9 22:54:02 UTC 2015


On 01/09/2015 04:05 PM, Chris Lumens wrote:
>> The basic reason we have issues trying to clear devices from disks with
>> partially-corrupt gpt disklabels is that we rely on pyparted to manage
>> partitions and disklabels and it currently does not allow us to proceed
>> with partially corrupt disklabels. I know clumens started looking into
>> making pyparted capable of letting us proceed in the face of a partially
>> corrupt gpt disklabel. If that gets done soon enough it would be relevant
>> here, especially if we decide the lvm part of these patches isn't suitable
>> for rhel7-branch.
>
> So, I've been looking at this a bit today and I think I've talked myself
> around in circles.  As I see it, I'm supposed to be making up a patch
> for pyparted that serves two purposes at the same time:
>
> (1) We do not want interactivity during disk discovery, but
> (2) We want people to be able to decide whether to proceed with a given
> disk or not.
>
> I'm having trouble reconciling these two seemingly at-odds requirements.

The reason I don't want to have interactivity during disk discovery is 
that means maintaining UI code in blivet to some extent. I'm comfortable 
with having the devicetree raise an exception when it finds a problem, 
possibly contingent upon the value of some flag(s). The dialog can 
determine if we try again to populate the tree or not, after either 
reconfiguring pyparted to allow the corrupt disklabel (via blivet flag?) 
or having the user resolve the matter in the shell.

The following just occurred to me. I haven't thought it through, but it 
seems worth mentioning. The tools used to populate the udevdb should 
agree with the kernel. That is, if udev tells us sda has a gpt disklabel 
(partially corrupt or not) we should not care what else might be on it. 
We should pursue handling that gpt disklabel. If that is true, we will 
always want to answer that particular question with PED_EXCEPTION_OK. 
None of that applies to isohybrid media, of course.

David

>
> I'd have an easier time of this with some pointers to where in
> blivet/anaconda we'd want to be able to make a decision about a given
> disk and what kind of interaction we want from the user.  I've got a
> couple ideas about what sorts of things I can do, I just need to know
> which direction to go in.
>
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>



More information about the anaconda-patches mailing list