[blivet:master 00/16] Patches related to _resizefsUnit

mulhern amulhern at redhat.com
Thu Jan 8 17:45:22 UTC 2015


Mostly the same as before except:

I ended up combining the revised version of
  Do not compare the same two values twice with
  Do not calculate Sizes unless they are needed.

I dropped:
  Add a new way of specifying Sizes().
  Use tuples to construct Sizes() wherever units are known.
since there is a better way of handling how we construct Sizes.

I dropped:
  Add _resizefsUnit to TmpFS and use in appropriate places
and I'll be adding it to my other patches related to TmpFS in due course.

The only changed patch is:
  Use _resizefsUnit in resizeArgs() method implementations.

so that's the only one I'm sending.

mulhern (16):
  Get rid of unnecessary use of long.
  Make possiblePhysicalExtents() a bit more direct.
  Do not compare the same two values twice.
  Avoid using Size constant in FileDevice._create().
  Eliminate redundant test.
  Comment _prefixTestHelper() and eliminate some redundancies.
  Hoist _BINARY_FACTOR * min_value calculation out of loop.
  Make _Prefix entries named constants.
  Add unitStr() method.
  Make _parseUnits() return a unit constant, rather than a number.
  Get whole unit tuple in loop when searching for correct units.
  Do not even pretend that ReiserFS is resizable.
  Change convertTo() and roundToNearest() so each takes a units
    specifier.
  Use convertTo in humanReadable().
  Do not supply a default implementation for the resizeArgs() method.
  Use _resizefsUnit in resizeArgs() method implementations.

 blivet/devicelibs/lvm.py          |  29 ++++-----
 blivet/devicelibs/swap.py         |  19 +++---
 blivet/devices/file.py            |   9 ++-
 blivet/devices/lvm.py             |  16 ++---
 blivet/devices/partition.py       |   8 +--
 blivet/formats/fs.py              |  44 +++++++------
 blivet/size.py                    | 130 +++++++++++++++++++-------------------
 tests/devicelibs_test/lvm_test.py |   5 --
 tests/size_test.py                |  92 ++++++++++++---------------
 tests/storagetestcase.py          |   4 +-
 10 files changed, 173 insertions(+), 183 deletions(-)

-- 
1.9.3



More information about the anaconda-patches mailing list