[blivet:master 17/17] Make TmpFS._resizable False.

Martin Kolman mkolman at redhat.com
Wed Jan 7 19:00:33 UTC 2015


On Tue, 2015-01-06 at 15:38 -0500, mulhern wrote:
> This doesn't change current operation at all, since it will be set to False
> in constructor anyway. But even if it weren't there are some problems:
> 
> * It will crash in FS.doResize() due to lack of resizefsUnit field.
> I have another patch set in which I address that, however...
> * Most filesystems do not need to be mounted to be resized, but tmpfs
> does because it uses mount. This means it does not fit well into the
> framework of resizing actions and so forth that the other filesystems
> fit into. This problem needs to be thought about fairly deeply.
> * TmpFS is not really able to find its current size. This is a tricky thing
> to do; it seems people tend to use some combination of du and df.
I think they probably know what they are doing when using blivet to
resize a volume. If we followed the same logic we would need to disable
resize for btrfs as well, because df also often reports very misleading
values with df in many cases due to snapshots, reflinks, metadata block
exhaustion and general madness.

So I "vote" to keep resize and just fixing the issues that prevent it
from working with latest code.
> 
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>  blivet/formats/fs.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
> index 06ecaf5..31b3688 100644
> --- a/blivet/formats/fs.py
> +++ b/blivet/formats/fs.py
> @@ -1544,7 +1544,6 @@ register_device_format(SysFS)
>  class TmpFS(NoDevFS):
>      _type = "tmpfs"
>      _supported = True
> -    _resizable = True
>      # remounting can be used to change
>      # the size of a live tmpfs mount
>      _resizefs = "mount"




More information about the anaconda-patches mailing list