[PATCH 2/3] Remove optional groups from environmentGroups

David Shea dshea at redhat.com
Wed Jan 7 17:49:00 UTC 2015


On 01/07/2015 12:32 PM, Adam Williamson wrote:
> On Wed, 2015-01-07 at 12:03 -0500, David Shea wrote:
>> This method is used in the software spoke to deselect groups added
>> via the environment, and having the optional groups in there doesn't
>> do any good since any selected optional groups would have been
>> selected by the user.
> I don't know exactly what the code is for, but just reading the commit
> message - is "any selected optional groups would have been selected by
> the user" 100% true? I believe comps allows the possibility of a
> 'default optional group', one that's selected by default (the
> difference between that and a non-optional one being that the user can
> choose not to have it). Not sure if that makes a difference to the
> change, but thought I'd point it out.

Sure is. Well, that doesn't work with dnf, either. Also it would be 
mighty nice if anything about comps was documented anywhere.


More information about the anaconda-patches mailing list