[blivet:master 00/17] Patches about mounting filesystems

Vratislav Podzimek vpodzime at redhat.com
Wed Jan 7 08:17:19 UTC 2015


On Tue, 2015-01-06 at 15:38 -0500, mulhern wrote:
> They are all fairly trivial tests or refactoring cleanups until
> "Substitute FS.mountopts...".
> 
> Because mounting and resizing are a bit mixed up in TmpFS, some
> of these patches are about both actions.
> 
> I had hoped to put in a satisfactory test about the resizability of TmpFS
> while I was at it, but it turned out that I really couldn't.
> 
> mulhern (17):
>   Add a tiny test for TmpFS.
>   Be less eager about processing all lines in /proc/meminfo.
>   Simplify setting options variable.
>   Simplify FS._getOptions().
>   Tighten up FS.mountable().
>   Virtualize options property methods in DeviceFormat.options
>     definition.
>   Eliminate some redundant definitions of the device property.
>   Add simple _sizeOption() method to TmpFS class.
>   Simplify TmpFS.resizeArgs() just a bit.
>   Substitute FS.mountopts for TmpFS._options instance variable.
>   Change TmpFS._getOptions() so it always appends _size_option.
>   Have TmpFS.resizeArgs() use default options if options not set.
>   Do not bother to set device.format.mountopts.
>   Set format's mountpoint if it has the mountpoint attribute.
>   Destrengthen self._size_option field.
>   Do not redefine size property in TmpFS.
>   Make TmpFS._resizable False.
> 
>  blivet/__init__.py            | 13 ++----
>  blivet/formats/__init__.py    |  6 ++-
>  blivet/formats/fs.py          | 98 ++++++++++++++-----------------------------
>  blivet/formats/swap.py        |  3 --
>  blivet/util.py                |  7 ++--
>  tests/formats_test/fs_test.py | 13 ++++++
>  6 files changed, 56 insertions(+), 84 deletions(-)
Apart from the two inline comments these all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list