[PATCH 0/4] unsetup dnf repos and other payload changes

Vratislav Podzimek vpodzime at redhat.com
Wed Jan 7 07:41:35 UTC 2015


On Tue, 2015-01-06 at 15:33 -0500, David Shea wrote:
> Patches 1 and 2 are just cleanups of unneeded code. 
> 
> Patch 3 handles the problem of accessing dnf payload properties before there's
> a payload to access by leaving empty data in unsetup payloads. This is kind of
> like all of those if not self._yumGroups lines in yumpayload.py, but not half a
> dozen places.
> 
> Patch 4 makes dnfpayload not crash is the base repo can't be setup, because
> that's really uncalled for.
> 
> David Shea (4):
>   Remove obsolete packaging code.
>   Remove the checks for whether dnf and rpm were imported
>   Make dnf._base and dnf._base.comps always available.
>   Don't treat the baserepo as special when gathering metadata (#1177502)
> 
>  pyanaconda/install.py                    |  2 +-
>  pyanaconda/packaging/__init__.py         | 56 +++-----------------------------
>  pyanaconda/packaging/dnfpayload.py       | 15 +++++----
>  pyanaconda/packaging/rpmostreepayload.py |  2 +-
>  pyanaconda/packaging/yumpayload.py       |  8 ++---
>  5 files changed, 19 insertions(+), 64 deletions(-)
These all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list