Patches for CentOS + Anaconda

David Shea dshea at redhat.com
Mon Jan 5 22:27:48 UTC 2015


On 01/05/2015 04:59 PM, Colin Walters wrote:
> My review:
>
> - I think installclasses/centos.py should inherit and override from rhel.py instead of being a copy
> - s/class InstallClass/class CentOSInstallClass/

I'm with you on those points as far making life easier for whoever 
maintains the CentOS installclass file but since it's their file in 
their tree I don't really have any strong opinions on how they do it.

> - We should consider a utility function like "if productIsRHELBased(productName)" or something to avoid the lots of if (rhel || centos)

The message I get from if (rhel || centos) changes is that such 
information should be part of the installclass in the first place. For 
the bootloader fstype, maybe we could check is the installclass 
defaultFS is one of the supported types for the bootloader and reorder 
stage2_format_types to put it first in that case. It shouldn't need to 
be checking the productName.

The other productName.startswith("Red Hat") that I see is for the 
unsupported hardware dialog, and I think if CentOS wants to add that in 
it should be an explicit thing they do and not something we activate 
based on just being rhel-based.

The other conditional I see added in the patch set is to disable 
fastestmirror if centos, and I think they could do that just be leaving 
fastestmirror off of the install media.

> - EULA location will need some dynamic autodetection

I don't have any bright ideas about this.


More information about the anaconda-patches mailing list