[master 1/1] Clarify the allocation error message (#1147974)

Brian C. Lane bcl at redhat.com
Fri Feb 27 22:40:26 UTC 2015


On Fri, Feb 27, 2015 at 02:30:29PM -0500, Anne Mulhern wrote:
> 
> 
> 
> 
> ----- Original Message -----
> > From: "bcl" <installerbot-noreply at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Friday, February 27, 2015 2:06:16 PM
> > Subject: [master 1/1] Clarify the allocation error message (#1147974)
> > 
> > From: "Brian C. Lane" <bcl at redhat.com>
> > 
> > "Unable to allocate requested partition scheme." is vague. Instead tell
> > the user there wasn't enough space.
> > ---
> >  blivet/partitioning.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/blivet/partitioning.py b/blivet/partitioning.py
> > index 9c3f47d..bc5ba67 100644
> > --- a/blivet/partitioning.py
> > +++ b/blivet/partitioning.py
> > @@ -813,7 +813,7 @@ def allocatePartitions(storage, disks, partitions,
> > freespace):
> >                  break
> >  
> >          if free is None:
> > -            raise PartitioningError(_("Unable to allocate requested
> > partition scheme."))
> > +            raise PartitioningError(_("Not enough free space to allocate the
> > requested partition scheme."))
> >  
> >          _disk = use_disk
> >          disklabel = _disk.format
> > 
> > 
> > --
> > To view this commit on github, visit
> > https://github.com/rhinstaller/blivet/commit/32948e9faa28611a6c0e77079d7bcf21f03c9821
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> That isn't always the problem...because partitioning is a subtle beast.
> 
> I had a discussion with dlehman back when I put this change in:
> 
> Here's the slightly garbled log message:
> 
>     Make partitioning error message more friendly (#1020388)
>     
>     Resolves: rhbz#1020388
>     
>     Automatic partitioning is complicated and may fail for a number of reasons
>     besides an absolute lack of space. This message is less misleading than
>     the previous two because it does seem to blame lack of space or a particular
>     partition.
> 
> There should be a "not" between "does" and "seem", unfortunately.

Ah darn, I was afraid of that. Well, I guess I'll close this until we
figure out a better way to tell users what's wrong.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list